Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1041

default idp.properties is missing idp.fticks.loghost + idp.fticks.logport

    XMLWordPrintable

    Details

    • Operating System:
      Multiple
    • Java Version:
      Other OpenJDK 7

      Description

      Hi,

      I greatly appreciate the F-TICKS logging framework that came with 3.2.

      I see most of it is configured in idp.properties:

      # F-TICKS auditing - set salt to include hashed username
      #idp.fticks.federation=MyFederation
      #idp.fticks.algorithm=SHA-256
      #idp.fticks.salt=somethingsecret
      
      • but the logging configuration also needs to get idp.fticks.loghost and idp.fticks.logport.

      I was first configuring this by changing the logback variable definition in logback.xml, but then I was pointed to this being also configurable in idp.properties - as logback.xml imports idp.properties.

      I think the recommended way of configuring this should be having all fticks configuration in one place, idp.properties - so would it be worth adding there also idp.fticks.loghost and idp.fticks.logport as commented-out entries with their default values? Like:

      # F-TICKS auditing - set salt to include hashed username
      #idp.fticks.federation=MyFederation
      #idp.fticks.algorithm=SHA-256
      #idp.fticks.salt=somethingsecret
      #idp.fticks.loghost=localhost
      #idp.fticks.logport=514
      

      I see the convention is to include all configurable settings as commented out entries in idp.properties - but I also see there are a number of other entries in logback.xml that could be considered for the same inclusion, and this might be over the top.

      Please take this just as a suggestion...

      Cheers,
      Vlad

        Attachments

          Activity

            People

            Assignee:
            cantor.2@osu.edu Scott Cantor
            Reporter:
            tuakiriadmin-vmencl@virtualhome.tuakiri.ac.nz Vladimir Mencl
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m