Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1237

Deprecated namespace check in AbstractDataConnectorParser has incorrect logic

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.3.2
    • Fix Version/s: 3.4.0
    • Component/s: Attribute Resolver
    • Labels:
      None

      Description

      The condition in AbstractDataConnectorParser.doParse() for checking if the deprecated "urn:mace:shibboleth:2.0:resolver:dc" is still being used is:

      if (!AttributeResolverNamespaceHandler.NAMESPACE.equals(suppliedQname.getNamespaceURI())) {
          // ...
          log.warn("{} Configuration contains at least one element in the deprecated '{}' namespace.",
               getLogPrefix(), DataConnectorNamespaceHandler.NAMESPACE);
          // ...
      }

      However, this doesn't check if the deprecated namespace is being used, but instead checks that the new merged namespace is only being used.  This means that any custom DataConnector implementations will cause the warning to be generated since they are not under "urn:mace:shibboleth:2.0:resolver".  To add to the confusion, the warning message also indicates that the deprecated namespace is being used even though it's not.

        Attachments

          Activity

            People

            Assignee:
            cantor.2@osu.edu Scott Cantor
            Reporter:
            arthur2@qut.edu.au Jamie Arthur
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 15 minutes
                15m