Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1334

3.3 to 3.4 upgrade doesn't do the right thing with webapp

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: Installer
    • Labels:
      None

      Description

      In 3.3 an install used to

      • move ${idp.home}/webapp to an archive folder
      • create a new ${idp.home}/webapp
      • populate it from the source disto
      • overcopy edit-webapp
      • Build the war

      This was wrong for a lot of reasons I'll no go into and so

      In 3.4, an install will

      • populate ${idp.home}/dist/webapp from the distro

      and when we build the war it

      • creates an new ${idp.home}/webapp
      • copies ${idp.home}/dist/webapp in
      • overcopy edit-webapp
      • build the war
      • delete ${idp.home}/webapp

      Note that 3.3 deleted /webapp at the start and 3.4 at the end

      The result is that for a 3.3 to 3.4 upgrade we will have a webapp withtwice as much stiff (all of 3.3 and all of 3.4). Windows is OK because with the windows install the windows technology takes care of deleteing the old version of ${idp.home}/webapp, But Unix is less happy.

      The fix is to delete ${idp.home}/webapp before building the war (which makes us more crash proof).

      We (Ian Young and I) would like to make the staging directory named something other than webapp (tmp-webapp even). I cannot see any reason why this is not a good idea, but I have a memory/concern that the name was kept for better reasons than "I just did't see why I shouldn't keep the name".

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ian@iay.org.uk Ian Young
              Reporter:
              rdw@iay.org.uk Rod Widdowson
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: