Missed Deprecations in 3.4
Description
Environment
Activity
Tom ZellerDecember 18, 2018 at 10:30 PM
Resolving issue prior to release.
Rod WiddowsonDecember 9, 2018 at 4:35 PM
And so it goes on.
The completely unsupported trust engines (the metadata ones) do not warn using DeprecationSupport, insteasd they say
log.warn("Configuration {} contained unsupported Trust Engine type {}. This has been ignored.", parserContext
.getReaderContext().getResource().getDescription(), DOMTypeSupport.getXSIType(element).toString());
That's enough for me to remove them from V4 -any anyway the only reason you';d have them would be because of use of the deprecated old style relying party.
It doesn't even seem to be worthwhile to even add the deprecations in 3.4.2, but I suppose we should just to be squeeky clean. I'll make the change in master and decide next week whether I I care enough to pull the change back into maint-3.4
Rod WiddowsonDecember 9, 2018 at 4:22 PM
Added a missed cherrypick (for the ResourcedBasedAttributeResolver with <Resource> children).
I need to exbed the contents of this case into an email to dev so we can have a discussio n about which of these deprecations can be removed in V4. Some are slam-dunks (The JNDI properties to RDBMS can go, the <SourceAttribute> to the template attribute must stay) others are marginal.
Rod WiddowsonDecember 9, 2018 at 2:44 PM
fixed 9e764d099 (miant-3.4) 2e71665abc9 (master)
Rod WiddowsonDecember 8, 2018 at 5:16 PM
@Scott Cantor just spotted that the check Attributes was DFW was data connectors. I'm fixing that and making the tests exercise this path (you cannot automate the test).
This is just a case to capture things which we failed log as deprecated in 3.4.* and hence need to either deprecate in 3.4.2 or (probably) continue to support in 4.0.0
Start with in
conf/c14n/subject-c14n.xml<!-- This is installed to support the old mechanism of using PrincipalConnectors in the attribute resolver to map SAML Subjects back into principals. If you don't use those (or this is a new install) you can remove this. --> <ref bean="c14n/LegacyPrincipalConnector" />Which means we need to
(in 3.4.*) add a deprecation warning into it constructor (to force its removal from that file and then we can remove it entirely in 4.0 or
In 4.0 leave it in place as an empty bean.
In all cases it can be removed from the webflow file in 4,.0 because it cannot be called