Deprecation of SourceAttribute in Template AttrDef created a regression
Basics
Logistics
Basics
Logistics
Description
The deprecation of the old SourceAttribute syntax created a regression because it's now generically processing all input fields from a legacy Dependency on a data connector, which causes it to commonly fail when not all of the inputs have the same number of values.
If there are SourceAttribute elements present, we should be deferring to them if possible.
Environment
None
Activity
Rod Widdowson January 3, 2019 at 4:48 PM
Rebased into maint-3.4 -> closing
Rod Widdowson January 3, 2019 at 2:26 PM
Turns out that there are no short cuts for the old/new style of things so we do what @Scott Cantor said we'd have to do,.
I did manage to hijack one of the tests into a suitable canary for this case though which is pleasing
Rod Widdowson January 2, 2019 at 4:49 PM
Right, I totally buy that we have to do it because its a regression I'm just hoping that I can limit the damage. And with a following wind it can all be jettisoned in V4 or V5
Scott Cantor January 2, 2019 at 4:37 PM
Yes, that's deliberate, and obviously doesn't impact upgrades.
Scott Cantor January 2, 2019 at 4:37 PM
We have to for compatibility. It's a basic "upgrade and existing behavior breaks" situation. I would buy that we don't have to do it if the new Dependency syntax is used, but that might be more complex than it's worth.
The deprecation of the old SourceAttribute syntax created a regression because it's now generically processing all input fields from a legacy Dependency on a data connector, which causes it to commonly fail when not all of the inputs have the same number of values.
If there are SourceAttribute elements present, we should be deferring to them if possible.