Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1399

Formalize getLogPrefix across all resolverPlugins (and wider?)

    XMLWordPrintable

    Details

      Description

      About half way through the development of V3 I introduced a method called getlogPrefix().  The idea is that is makes is super easy to log

      log.debug("{} some message {}", getlogPrefix(), ...); 

      The LogPrefix is usually derived from the plugin Id plus its type

      DataConnector 'Whatever' : some message 42

      I was just in the position of wanting to add a log message to the ValueMap logging and discovered that there wasn't a getlogprefix.

       

      It would be nice to be able to rely on this across all the objects that the attribute resolvers and filters use.  I propose that we add this, possibly via an interface which everything gets to implement.

       

      It might also be cute to add a setter to this interface so we can automatically populate the line number and file in our custom spring parsers this could then drive the default setting.

      Having now had a dangerous level of exposure to the SP I really want to reach for multiple inheritance to do this, but I suspect that we can manage most of the work with helper classes.

      If we made this wider, is there some wunder-SAL which we could inject to populate this stuff from native Spring? 

      p:logPrefixData(#'SomethingWonderful')

      I'll leave that to Scott Cantor to consider as oart of the winder V4 story

       

        Attachments

          Activity

            People

            Assignee:
            rdw@iay.org.uk Rod Widdowson
            Reporter:
            rdw@iay.org.uk Rod Widdowson
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: