I started looked and got lost so I need to go back in time and read some code and refresh memory is.
- In V3.4 SAML1StringNameIdentifier (encoder) and it's friends are deprecated (but promoted to the flattened schema)
- Aside: SAML2NameID (attribute) / SAML2XMLObject (encoder) most definitely isn't.
- This ties into the NameID generation stuff via all sorts wiring specifically for legacy NameID generation
- Which might argue that said wiring can be rationalized.
The first bullet is easy and could be part of
IDP-1121, moving down the bullet lists moves me out of my comfort zone (but into code I need to re-learn) whilst at the same time moves us into higher risk of merge conflicts.
Nonetheless it feels important follow through and complete the unpicking so I'm opening a new case. That way I can start the work and put it aside until we open master for all comers.
Hence a separate case