Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1430

Review and cleanup of ProfileConfig classes

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0
    • Component/s: Configuration
    • Labels:
      None

      Description

      We have some inconsistent naming of methods that deal with boolean properties in the config later because of the late addition of Predicate support, and the classes as a whole use an internal trick to get at the ProfileRequestContext or MessageContext when evaluating properties to support the metadata-driven lookup features.

      I think what we want is to actually change all those APIs to explicitly take a context object in all the getFoo methods to avoid the trickery, and probably should revisit the naming and consistency of the methods at that point.

      My thought is to possibly use getFooPredicate/setFooPredicate and then add isFoo or hasFoo or what have you as new methods that take the context object and evaluate the underlying Predicate to produce the boolean.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              cantor.2@osu.edu Scott Cantor
              Reporter:
              cantor.2@osu.edu Scott Cantor
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 4 hours, 15 minutes
                  2d 4h 15m