Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1555

Optimize entityID-based predicates in MetadataFilter parsers

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 4.0.0
    • Component/s: Configuration, Metadata
    • Labels:
      None

      Description

      May not get done for 4.

      The Spring parsers for the various filters that rely on that <Entity>foo</Entity> style where it generates EntityIdPredicate objects around those elements aren't optimal. Instead of building one Predicate around a number of Entity elements so the eventual test is one check against a Set<String>, it turns into N Predicates with a single String, or'd together. So the check is O(N) instead of a more optimal HashSet lookup.

      There are some use cases where there's no practical way to express the proper set of SPs except a big hellacious list, so this could be meaningful in those cases. Algorithms come to mind.

        Attachments

          Activity

            People

            Assignee:
            cantor.2@osu.edu Scott Cantor
            Reporter:
            cantor.2@osu.edu Scott Cantor
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 45 minutes
                45m