Spring schema metafiles have stale references
Description
Environment
Activity
Scott CantorJune 24, 2020 at 11:08 PM
Pending the next release, I've redone the rewrite rules to direct requests for the older schemas not in 4.0 to the 3.4.6 tagged versions.
Scott CantorJune 24, 2020 at 10:57 PM
The best option seems to be putting the old files back so that once we release again, the schema redirects will just start working again for older files to validate against. This is committed.
I also verified that validating files in Eclipse, and I'm sure other Java-based XML editors, is causing dereferences of the old locations that look essentially the same as the IdP doing it by accident.
Scott CantorJune 24, 2020 at 9:23 PM
I posted a summary to committers but the upshot is that we are opening the IdP up to trying to remotely access old schema URLs right now, and we need to put classpath resources back into idp-schemas to short-circuit that. They probably could be empty or just bare schema elements, will continue to test that.
Also need to see if Eclipse may be deref'ing these, which is annoying but I'm less angry about.
Scott CantorMay 29, 2020 at 1:47 PM
And of course I forgot to ask. I think if we "fix" this it may end up being a server side fix anyway, but scheduling out.
Scott CantorApril 7, 2020 at 6:39 PM
Setting blocker so I remember to ask about this.
I don't think it's really hurting anything, but I noticed the META-INF/spring.schemas file contains references to removed schemas.
Since any use of those schemas would fail anyway, it's just moving errors around at worst, but we should probably consider what the "right" answer is. Removing the http:// aliases would cause references to go online, and that may be a good enough reason to leave them, but perhaps they should point to a dummy resource rather than a non-existent one?