Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1625

CSRF token missing in Duo cancel request hyperlink

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0, 4.0.1
    • Fix Version/s: 4.1.0
    • Component/s: Duo
    • Labels:
      None

      Description

      The 'Cancel this request' hyperlink in the Duo.vm template does not contain the required csrf_token parameter in the URL. Hence clicking on this link triggers an invalid_csrf token error - iff CSRF protection is enabled.

      This can be conditionally appended to the hyperlink (currently on line 65 with eventId=cancel) e.g replace the existing href.

      $flowExecutionUrl&_eventId=cancel
      

      With the href:

      $flowExecutionUrl&_eventId=cancel#if($csrfToken)&${csrfToken.parameterName}=${csrfToken.token}#{else}#end
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              philip.smart@corp.jisc.ac.uk Philip Smart
              Reporter:
              philip.smart@corp.jisc.ac.uk Philip Smart
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours
                  2h