Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-1774

uninstalling a module should remove .idpnew files associated with its resources

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Configuration
    • Labels:
      None

      Description

      If you have a module enabled and change some of its resources, such as XML configuration, a subsequent upgrade will cause the new default configuration to be written to an .idpnew file.

      If you're upgrading from a pre-4.1 release, you inevitably end up with a number of these files, as many modules will be deduced as being enabled due to the presence of the default XML configuration from your original, perhaps long-ago installation. Of course, this will also happen if you have modified that default. This is good.

      In the immediate post-4.1-upgrade situation a lot of existing deployers will find themselves in, they will be tempted to disable a lot of those modules as many won't really be in use. Using the --clean option will also cause the resources associated with the module (in this case, the deployer's previous copy of the resource, modified or not) to be removed. This is also good and matches the deployer's intent.

      However, as things stand, the .idpnew files are not removed, and the only remnant of the install-pre-4.1 / upgrade to 4.1 / disable modules process will be the default configuration for 4.1 which the deployer has never used and which contains no unretrievable information as it was part of the 4.1 distribution. The resource file will of course be recreated with that same content should the deployer enable the module again.

      I think it would be better if module --remove --clean always removed associated .idpnew files so that there will be no trace left of the module at all.

        Attachments

          Activity

            People

            Assignee:
            cantor.2@osu.edu Scott Cantor
            Reporter:
            ian@iay.org.uk Ian Young
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m