Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-558

installer log file formatting issue

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.1.0
    • Component/s: Installer
    • Labels:
      None

      Description

      The build.xml file contains things like this:

          <echo append="true" file="idp_ant.log">target: Preload
          </echo>
      

      This causes odd formatting of the log file because of the tabs/spaces preceding the closing tag. Except for the first thing in the log file, of course.

      This would be cleaner if the following were used instead, per the Ant documentation:

          <echo append="true" file="idp_ant.log">target: Preload${line.separator}</echo>
      

      This would be even cleaner as well as more DRY if we defined something like this at the top:

      	<macrodef name="LOG">
      	  <attribute name="t"/>
      	  <sequential>
      	    <echo append="true" file="idp_ant.log">target: @{t}${line.separator}</echo>
      	  </sequential>
      	</macrodef>
      

      Then:

         <LOG t="Preload"/>
      

        Attachments

          Activity

            People

            Assignee:
            ian@iay.org.uk Ian Young
            Reporter:
            ian@iay.org.uk Ian Young
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 27 minutes
                27m