Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-646

RequiredValidUntil parser silently accepts deprecated numeric input and handles it as milliseconds

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.1
    • Component/s: Configuration
    • Labels:
      None

      Description

      This case from a case discussed in users [1]

      Right up until 13/Mar/15 the documentation said that the value of maxValidityInterval was seconds, although providing a value would issue a warning:

      11:23:30.804 WARN [e.i.m.s.c.c.SpringConfigurationUtils:276] - Numerical duration form is deprecated. The property 'maxValidityInterval' on metadata filter of type

      {urn:mace:shibboleth:2.0:metadata}

      RequiredValidUntil should use the duration notation: P0Y0M0DT0H0M6.000S

      Of course in V3 this is all automagically handled and any @Duration specified erroneously is converted into milliseconds.

      If the documentation hadn't wrongly specified seconds until so recently I'd be tempted to say "breakage in V3", but I'd probably resist the temptation.

      Fixing this is going to be a bit cumbersome (we need to introduce a factory bean). With that in place we have two options

      1) Continue the nonsense about it being seconds and warning
      2) Just saying this was deprecated in V2. It just doesn't work in V3.

      I don't know which we should do, but I'll prepare the fix.

      Also - should we (in the next non patch release) investigate adding a warning similar to the above in DurationToLongConverter? It could get pretty noisy.

      Thoughts?

      [1] http://shibboleth.net/pipermail/users/2015-March/020151.html

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rdw@iay.org.uk Rod Widdowson
                Reporter:
                rdw@shibboleth.net Rod Widdowson
              • Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4 hours
                  4h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours Time Not Required
                  3h