Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-648

Investigate warning on all numeric input to @Duration

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 3.1.0
    • Fix Version/s: 3.2.0
    • Component/s: Configuration
    • Labels:
      None

      Description

      We have a spring converter (net.shibboleth.ext.spring.config.DurationToLongConverter) which converts ISO8601 into milliseconds. (PT3S => 3000)

      If it encounters a non-duration is tries to interpret this as a long.

      This is active for both custom and nativ syntax.

      In case #IdP-646 we encountered a case where this was too helpful.

      I should like to make all use of non durations as input to @Duration a warning, this avoids any confusion about units. However I fear that this would become very noisy and so we need to investigate this - turn it on and see how noisy it actually is.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rdw@iay.org.uk Rod Widdowson
              Reporter:
              rdw@iay.org.uk Rod Widdowson
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4 hours
                  4h
                  Remaining:
                  Time Spent - 1 hour Remaining Estimate - 3 hours
                  3h
                  Logged:
                  Time Spent - 1 hour Remaining Estimate - 3 hours
                  1h