Uploaded image for project: 'Identity Provider'
  1. Identity Provider
  2. IDP-860

Failed to update to 3.2 due to lost class PreferExplicitOrderComparator

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Invalid
    • Affects Version/s: 3.2.0
    • Fix Version/s: None
    • Component/s: Attribute Consent
    • Labels:
      None

      Description

      This is probably not an issue, but noting it.

      When I tested the windows installers they failed. I diagnosed this to this stanza in consent-intecept-config.xml

       <alias alias="shibboleth.consent.attribute-release.AttributeIDComparator"
      	 	             name="shibboleth.consent.attribute-release.DefaultAttributeIDComparator" />
      	 	 
      	 	     <bean id="shibboleth.consent.attribute-release.DefaultAttributeIDComparator"
      	 	         class="net.shibboleth.idp.consent.logic.PreferExplicitOrderComparator"
      	 	         c:order-ref="shibboleth.consent.attribute-release.WhitelistedAttributeIDs" />
      

      PreferExplicitOrderComparator has moved to .impl whereas previously it was in the inferred impl module idp-consent.

      I remember doing this, but I could not remember where I got the intructions, but it looks like it was in https://issues.shibboleth.net/jira/browse/IDP-624

      I removed the stanza and all was OK.

      So the question is whether this matters, whether having mentioned a class (which isn;t obviously impl, even though it is) in a JIRA case means we need to keep it around forever

        Attachments

          Activity

            People

            Assignee:
            tzeller@shibboleth.net Tom Zeller
            Reporter:
            rdw@iay.org.uk Rod Widdowson
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: