Uploaded image for project: 'OpenSAML 2 - Java'
  1. OpenSAML 2 - Java
  2. JOST-174

ChainingMetadataProvider calls clear() on unmodifiable list

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.2
    • Component/s: None
    • Labels:
      None

      Description

      in method setProviders, code is:

      if (newProviders == null || newProviders.isEmpty())

      { providers.clear(); return; }

      but the default object for providers is:

      providers = Collections.EMPTY_LIST;

      This was changed between 2.3.1 and 2.5.1. In 2.3.1, providers was an empty array list.

      I believe the fix to this is to replace providers.clear() with providers = Collections.EMPTY_LIST.

        Attachments

          Expenses

            Activity

              People

              • Assignee:
                lajoie@shibboleth.net Chad La Joie
                Reporter:
                philvarner@idp.protectnetwork.org philvarner@idp.protectnetwork.org
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: