Eclipse and Checkstyle 8.1+ compatibility issues
Description
Environment
Activity
Tom ZellerMarch 8, 2018 at 1:48 AM
Needed to re-update some of the Java 7 Jenkins project-nightly jobs to not call site, not sure how I missed them the first time. Tomorrow (Thu Mar 8) all v7 jobs should pass.
Tom ZellerMarch 6, 2018 at 6:06 PM
Updated IdP 3.4 stack :
java-parent-project
maint-7
8da694807517fe5f16fce3f9e3e3912fbebe1596
java-support
maint-7
0c0518a2e38b95d33f61af0ddef6ebb27d1a09ee
spring-extensions
maint-5
c6ed871d735da8a2bccb6f7caf9da56248de1550
java-opensaml
master
0cf966304e1a1a6beedad9ff5cf4feba2ab165fd
java-identity-provider
master
19bea6a0b9bd82c04af8daeb6527aacaf5785597
Tom ZellerFebruary 19, 2018 at 9:02 PM
It would be nice to get Checkstyle working in Eclipse again, so I created new Jenkins jobs in order to separate building and deploying the Maven site :
java-support-v7-nightly-site
spring-extensions-v5-nightly-site
java-opensaml-nightly-site
java-opensaml-v3.3-nightly-site
java-identity-provider-nightly-site
java-identity-provider-3.3-nightly-site
The project-nightly jobs :
use Java 7
do not :
run
site site site:stage site:deployPublish Checkstyle analysis results
Publish HTML reports (target/site as Site Report)
The project-nightly-site jobs :
use Java 8
run only
site site:stage site:deployPublish Checkstyle analysis results
Publish HTML reports (target/site as Site Report)
Publish Javadoc (target/site/apidocs)
Each _project_-nightly job triggers the project-nighty-site job.
First run of these jobs is today, hopefully I made no mistakes.
Ian YoungJanuary 26, 2018 at 6:15 PM
java-support change in commit 02be872e21f1f70ca0d3e4290604ee6b525d6fc8
Ian YoungJanuary 26, 2018 at 6:07 PM
spring-extensions change in commit fee14953602f2245ff647a2910c7fa8c7179adfb
It looks like the Checkstyle folks made some more backwards-breaking changes. Our current standard checkstyle.xml fails in Eclipse with the following error:
Checkstyle execution failed due to an internal error. Please check the error log for details...This seems to be down to a change in V8.2 where the
FileContentsHolderclass was removed, and the fix is to remove the reference to that (everywhere) while bumping the version of Checkstyle we use outside Eclipse to match Eclipse's uses of V8.5.