Uploaded image for project: 'Metadata Aggregator'
  1. Metadata Aggregator
  2. MDA-171

method contract inconsistent with annotations

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.1
    • Fix Version/s: 0.10.0
    • Component/s: SAML Metadata
    • Labels:
      None
    • Operating System:
      Multiple

      Description

      SAMLMetadataSupport.getDescriptorExtensions has comments implying that its parameters are never null. However, if that contract is violated by the caller the method simply returns null, and the parameters are actually annotated as @Nullable.

      I can't see a benefit to this approach; it makes more sense to simply annotate and enforce a @Nonnull constraint on both parameters.

        Attachments

          Activity

            People

            Assignee:
            ian@iay.org.uk Ian Young
            Reporter:
            ian@iay.org.uk Ian Young
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 27 minutes
                27m