Refactor DOM traversal with more general context mechanism
Basics
Technical
Logistics
Basics
Technical
Logistics
Description
The DOM traversal framework in AbstractDOMTraversalStage is based around a very general (and probably not cheap) TraversalContext involving a ClassToInstanceMultiMap. In practice, though, all the actual uses of this would be better implemented using custom data for the particular traversal.
Refactor this framework to define a base TraversalContext which is then specialised for the particular job in hand.
Environment
None
Activity
Show:
Ian YoungAugust 8, 2017 at 3:57 PM
Added more of a description of the new structure to the release notes.
Ian YoungAugust 8, 2017 at 3:43 PM
Done in commit 2660ba0c241a6fac3c443ca19573573906a93b53.
Details ended up being a little different: there's an interface called DOMTraversalContext, and a simple implementation of that called SimpleDOMTraversalContext. The simple implementation is used in a number of the existing subclasses of AbstractDOMTraversalStage where customisation of the traversal context wasn't required.
The DOM traversal framework in
AbstractDOMTraversalStageis based around a very general (and probably not cheap)TraversalContextinvolving aClassToInstanceMultiMap. In practice, though, all the actual uses of this would be better implemented using custom data for the particular traversal.Refactor this framework to define a base
TraversalContextwhich is then specialised for the particular job in hand.