Uploaded image for project: 'Metadata Aggregator'
  1. Metadata Aggregator
  2. MDA-192

move SAML-specific methods down from AbstractDOMTraversalStage

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.10.0
    • Component/s: DOM Metadata, SAML Metadata
    • Labels:
      None

      Description

      AbstractDOMTraversalStage includes a couple of helper methods which are SAML-specific: ancestorEntity and addError.

      It would be fine to introduce an abstract subclass (e.g., AbstractSAMLTraversalStage to house these, but a more general approach involving a new abstract errorPrefix method might be better.

      At present, ancestorEntity is only used by addError and that is only used in CRDetectionStage, so an even simpler solution would be to make both methods private and move them down there for now.

        Attachments

          Activity

            People

            Assignee:
            ian@iay.org.uk Ian Young
            Reporter:
            ian@iay.org.uk Ian Young
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 3 minutes
                1h 3m