Uploaded image for project: 'Metadata Aggregator'
  1. Metadata Aggregator
  2. MDA-218

Test for DOMResourceSourceStage should not fetch from google.com

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.10.0
    • Component/s: DOM Metadata
    • Labels:
      None

      Description

      The testSuccessfulFetchAndFailedParse test for DOMResourceSourceStage (currently in a misnamed test class, but that's a separate question) references an external web site as follows:

      Resource mdResource =
          new UrlResource("http://www.google.com/intl/en/images/about_logo.gif");
      

      There's some suspicion that this can cause the test to hang. In any case, referencing an external resource just to generate a parse failure isn't necessary, and we should rework this to use a local (even embedded, as in one of the other tests) resource.

      This needs to be cherry-picked onto the 0.9 branch as that's where the test hang was observed.

        Attachments

          Activity

            People

            Assignee:
            ian@iay.org.uk Ian Young
            Reporter:
            ian@iay.org.uk Ian Young
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: