JPA Storage specifies length for record value

Description

The JPAStorageRecord class specifies a column length of 255 for the record value.
The value should be defined as a clob.

Remove the length designator and add the @LOB annotation.

Environment

None

is related to

Activity

Show:

Daniel Fisher February 11, 2015 at 2:07 PM

Fixed in r4218.

Scott Cantor February 3, 2015 at 8:55 PM

Implementation-wise, the context and key fields could be "configurable" in the sense that if the deployer created a larger column and accurately signaled that, things could work.

The value size is included in the Capabilities interface, but that's kind of a new thing I added, and none of my calling code actually checks it. Basically because it just doesn't work well, all that could do is get you a graceful error and a non-functional system, so it doesn't help much and adds a lot of overhead to the code. I probably should just deprecate that getValueSize() method.

Scott Cantor February 3, 2015 at 8:52 PM

Yes, the thread basically repeats the same comment I sent to users.

The suggested schema in the SP is here:
https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPODBCStorageService

I've used 255 for the context and key, and given memcache's 250 limit, I've not tried to push for anything longer and focused on making sure client code can adapt to the limit.

Tom Zeller February 3, 2015 at 8:46 PM

Here's a thread from the last time we talked about this.

http://marc.info/?l=shibboleth-dev&m=140778081823190&w=2

Tom Zeller February 3, 2015 at 8:44 PM

Can the size limits be configurable, via properties or XML or ?

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Fix versions

Affects versions

Created February 3, 2015 at 3:43 PM
Updated May 10, 2015 at 8:22 PM
Resolved February 11, 2015 at 2:07 PM