Uploaded image for project: 'OpenSAML - Java'
  1. OpenSAML - Java
  2. OSJ-234

Reset next dynamic metadata refresh when entity is unchanged.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: SAML 2 Metadata
    • Labels:
      None

      Description

      One of the gaps I think I noted in the dynamic metadata code is that it's possible for the underlying origin fetch to return a null, which causes the original resolve step to reuse the existing metadata if it's stil valid. But I believe it's not changing the underlying store metadata that governs the next refresh, which means this would cause endless repeats of the refresh attempt until it finally loads a new instance (if ever).

      I would suggest repeating the orignal computation of the next refresh time as though the metadata was newly acquired to ensure this doesn't repeat over and over.

      This would facilitate some of the extended behavior I'd like to see being implemented by deployer plugins at the load/store layer since they can do their own caching and selective refresh logic by just returning a null.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              putmanb@shibboleth.net Brent Putman
              Reporter:
              cantor.2@osu.edu Scott Cantor
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: