redirectLimit parser typo

Basics

Technical

Logistics

Basics

Technical

Logistics

Description

I've just read the code with no test, but it seems to have mistakes in the last 2 "exact+host"s.
http://svn.shibboleth.net/view/cpp-sp/branches/REL_2/shibsp/impl/XMLServiceProvider.cpp?annotate=3572

if (!strcmp(redirectLimit.second, "exact+whitelist"))
    m_redirectLimit = REDIRECT_LIMIT_EXACT_WHITELIST;
else if (!strcmp(redirectLimit.second, "exact+host"))
    m_redirectLimit = REDIRECT_LIMIT_HOST_WHITELIST;
else if (!strcmp(redirectLimit.second, "exact+host"))
    m_redirectLimit = REDIRECT_LIMIT_WHITELIST;

Document indicates "host+whitelist" and "whitelist" respectively.

Environment

None

Activity

Scott Cantor
June 1, 2012 at 4:37 PM

http://svn.shibboleth.net/view/cpp-sp?rev=3687&view=rev

Thank you! Always great to have a second set of eyes.

Resize issue view side panel

Fixed

Details

Assignee

Scott Cantor

Reporter

Takeshi Nishimura

Created June 1, 2012 at 9:48 AM

Updated August 4, 2021 at 9:24 PM

Resolved June 1, 2012 at 4:37 PM

redirectLimit parser typo

Description

Environment

Activity

Scott Cantor June 1, 2012 at 4:37 PM

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Scott Cantor
June 1, 2012 at 4:37 PM