Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ignoreCase option for PathRegex uses inverted logic

Description

We find that a configuration with

<PathRegex regex="Logs/" authType="shibboleth" requireSession="true"
ignoreCase="true" />

allows access without a session to

https://<server>/logs/

Changing the value for ignoreCase from 'true' to 'false' changes the behavior. We believe this logic is inverted compared to the name of the attribute and its documentation.

This has been specifically tested with SP 2.5.6 64 bit on Windows 2008 R2 with IIS 7.

Environment

None

Activity

Show:

Scott Cantor June 13, 2016 at 2:20 PM

I'd rather just warn every time and not have anything that weird going on in the code.

http://git.shibboleth.net/view/?p=cpp-xmltooling.git;a=commit;h=36fbea51f878ad3d7b1a844e405e18ae38d7d8e1

Rod Widdowson June 13, 2016 at 2:08 PM

I did, particularly in a release which (in one breath) introduces an attribute and deprecates the old one it seemed churlish to whine quite so much.

But I'd not die in a ditch to leave it like that. We could pull the warn entirely or just issue it every time (which will not be a huge number of times).

I'll let you decide.

Scott Cantor June 13, 2016 at 1:43 PM

I'll add some commenting, but otherwise the SP changes look good once I wrapped my brain into a pretzel.

Scott Cantor June 13, 2016 at 1:07 PM

Did you intend the flag in the getCaseSensitive function to be static? I think maybe you meant it to avoid repeated warnings about the issue across calls, but I'm still leery of a static like that. Not sure it's worth trying to do that.

Rod Widdowson June 10, 2016 at 12:33 PM

I think that I'm done, but because of the visibiloty of this one I'd appreciate it if Scott would review the code +doc prior to resolution

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created April 27, 2016 at 7:43 PM
Updated June 22, 2021 at 10:53 PM
Resolved June 13, 2016 at 2:21 PM
Configure

Flag notifications