Commit 92380630c4c151f5bf3205ed816a06ef018c52b2 to resolve introduces a bad if-check on the lastAccess variable in shibsp/impl/StorageServiceSessionCache.cpp in the hunk starting at line 1623:
This causes SSCache::find() to always report sessions as timed out if called from the shibd side and if given a timeout to enforce. I couldn't find any immediate cases that were affected, but custom handlers that people write may be (as is the case for me).
Environment
None
Activity
Scott Cantor
July 5, 2016 at 2:51 PM
Thanks. I did a code review and I believe that all of the out of process calls to this find method are called with null in the timeout parameter, preventing the bug from fatally affecting current behavior. If that turns out to be wrong, we'll need to ship a patch update.
Commit 92380630c4c151f5bf3205ed816a06ef018c52b2 to resolve introduces a bad if-check on the lastAccess variable in shibsp/impl/StorageServiceSessionCache.cpp in the hunk starting at line 1623:
This causes SSCache::find() to always report sessions as timed out if called from the shibd side and if given a timeout to enforce. I couldn't find any immediate cases that were affected, but custom handlers that people write may be (as is the case for me).