Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Modify Subrevision on zlib (and other relevevant DLLS) to take account of new build

Description

As per discussion in the dev list.

Such a change needs to

  • Automated

  • future proof.

Current working plan is to revew the guids in the master revision of versions.props and compare with the latest installer.  If the guids are the same

  • Take a local copy of the rc file for the dependency in question and edit it

  • Arrange for it to be used in the build

  • Arrange that if the file version name is changed moving forward then the build fails with a note to see whether we

    • Need to do the same again for the latest version

    • Of if the version is different from the one shipping we can revert the change

Environment

None

Activity

Show:

Rod WiddowsonMarch 15, 2018 at 11:16 AM

Implement in the source for log4shib and semi-automated for zlib.

Withjout attention the build will fail when we rev zlib next time (which is what we want).

Rod WiddowsonMarch 14, 2018 at 3:52 PM

log4shib done by editing the VC15 resource file directly.  This makes us safe against this issue for this DLL ongoing (since all VC10 builds will use a different rc file)

Rod WiddowsonMarch 14, 2018 at 3:41 PM

Discussion was here

Log4shib needs the same treatment as zlib

Done

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created March 14, 2018 at 1:33 PM
Updated July 17, 2018 at 2:48 PM
Resolved March 15, 2018 at 11:16 AM